New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coprocessor, dag: add IfJson, IfNullJson signature and some flags. #2264

Merged
merged 2 commits into from Sep 8, 2017

Conversation

Projects
None yet
3 participants
@hicqu
Contributor

hicqu commented Sep 7, 2017

Add two signatures: IfJson and IfNullJson. And use some new flags instead of Decimal to pass extra information about Json fields.

@hicqu hicqu requested review from AndreMouche, BusyJay and disksing Sep 7, 2017

@hicqu hicqu changed the title from coprocessor, dag: fix something about json. to coprocessor, dag: add IfJson, IfNullJson signature and some flags. Sep 7, 2017

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 7, 2017

Contributor

LGTM

Contributor

BusyJay commented Sep 7, 2017

LGTM

@@ -505,7 +505,10 @@ impl FnCall {
row: &'a [Datum],
) -> Result<Option<Cow<'a, Json>>> {
let val = try_opt!(self.children[0].eval_int(ctx, row));

This comment has been minimized.

@AndreMouche

AndreMouche Sep 8, 2017

Member

Should we consider Json::None?

@AndreMouche

AndreMouche Sep 8, 2017

Member

Should we consider Json::None?

This comment has been minimized.

@hicqu

hicqu Sep 8, 2017

Contributor

We don't need do that.

@hicqu

hicqu Sep 8, 2017

Contributor

We don't need do that.

@hicqu hicqu merged commit e40d007 into master Sep 8, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hicqu hicqu deleted the qupeng/json-others branch Sep 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment