New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

threadpool: fix race #2266

Merged
merged 5 commits into from Sep 11, 2017

Conversation

Projects
None yet
4 participants
@BusyJay
Contributor

BusyJay commented Sep 8, 2017

Notify should be called while holding the lock.

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 8, 2017

Contributor

PTAL

Contributor

BusyJay commented Sep 8, 2017

PTAL

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 8, 2017

Contributor

CI failed

Contributor

siddontang commented Sep 8, 2017

CI failed

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 8, 2017

Contributor

PTAL

Contributor

BusyJay commented Sep 8, 2017

PTAL

@siddontang

LGTM

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 9, 2017

Contributor

PTAL @overvenus

Contributor

siddontang commented Sep 9, 2017

PTAL @overvenus

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Contributor

siddontang commented Sep 11, 2017

@overvenus

Rest LGTM

Show outdated Hide outdated src/util/threadpool.rs

BusyJay added some commits Sep 11, 2017

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 11, 2017

Collaborator

LGTM.

Collaborator

disksing commented Sep 11, 2017

LGTM.

@BusyJay BusyJay merged commit a28e360 into master Sep 11, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@BusyJay BusyJay deleted the busyjay/fix-race branch Sep 11, 2017

BusyJay added a commit that referenced this pull request Sep 11, 2017

zhangjinpeng1987 added a commit that referenced this pull request Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment