New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roughly cleanup data between regions gap #2273

Merged
merged 4 commits into from Sep 12, 2017

Conversation

Projects
None yet
4 participants
@zhangjinpeng1987
Member

zhangjinpeng1987 commented Sep 11, 2017

No description provided.

// we treat CF_LOCK especially. For the others column families: 1) the data set
// in these column families usually are very large, so we don't want to trigger
// seek for these column families; 2) keys in these column families have ts tail,
// so end_key never exists in these column families.
if cf == CF_LOCK {

This comment has been minimized.

@siddontang

siddontang Sep 11, 2017

Contributor

I think we can ignore lock and raft and let outer clean up the region.

@siddontang

siddontang Sep 11, 2017

Contributor

I think we can ignore lock and raft and let outer clean up the region.

This comment has been minimized.

@zhangjinpeng1987

zhangjinpeng1987 Sep 11, 2017

Member

This function only used in quickly cleanup data between regions gaps, there is no more
other cleanup outer.

@zhangjinpeng1987

zhangjinpeng1987 Sep 11, 2017

Member

This function only used in quickly cleanup data between regions gaps, there is no more
other cleanup outer.

This comment has been minimized.

@siddontang

siddontang Sep 11, 2017

Contributor

So when we really clean up all data for the region? Will leave some stale data?

@siddontang

siddontang Sep 11, 2017

Contributor

So when we really clean up all data for the region? Will leave some stale data?

This comment has been minimized.

@zhangjinpeng1987

zhangjinpeng1987 Sep 12, 2017

Member

Yes, will leave some stale data, but if we don't have a mechanism to roughly cleanup these stale data, there is a risk that the stale data may increase to very huge.

@zhangjinpeng1987

zhangjinpeng1987 Sep 12, 2017

Member

Yes, will leave some stale data, but if we don't have a mechanism to roughly cleanup these stale data, there is a risk that the stale data may increase to very huge.

@ngaut ngaut assigned BusyJay and unassigned BusyJay Sep 11, 2017

@ngaut ngaut requested a review from BusyJay Sep 11, 2017

Show outdated Hide outdated src/util/rocksdb/mod.rs
@huachaohuang

LGTM

@zhangjinpeng1987 zhangjinpeng1987 merged commit 8c89a1a into master Sep 12, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zhangjinpeng1987 zhangjinpeng1987 deleted the zhangjinpeng/roughly-cleanup branch Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment