New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop thread pool before quitting scheduler #2275

Merged
merged 4 commits into from Sep 11, 2017

Conversation

Projects
None yet
4 participants
@huachaohuang
Member

huachaohuang commented Sep 11, 2017

Quitting scheduler without stopping thread pool can cause potentially coredump.

@huachaohuang huachaohuang requested review from BusyJay and overvenus Sep 11, 2017

@siddontang

Rest LGTM

@ngaut

This comment has been minimized.

Show comment
Hide comment
@ngaut

ngaut Sep 11, 2017

Member

LGTM

Member

ngaut commented Sep 11, 2017

LGTM

@huachaohuang

This comment has been minimized.

Show comment
Hide comment
@huachaohuang
Member

huachaohuang commented Sep 11, 2017

PTAL @BusyJay

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 11, 2017

Contributor

LGTM

Contributor

BusyJay commented Sep 11, 2017

LGTM

@huachaohuang huachaohuang merged commit fb28287 into master Sep 11, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@huachaohuang huachaohuang deleted the huachao/quit branch Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment