New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: no need to check region id 0. #2276

Merged
merged 2 commits into from Sep 12, 2017

Conversation

Projects
None yet
3 participants
@disksing
Contributor

disksing commented Sep 11, 2017

No description provided.

@disksing disksing requested review from siddontang and BusyJay Sep 11, 2017

@siddontang

LGTM

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Contributor

siddontang commented Sep 11, 2017

PTAL @overvenus

};
future::result(res).map_err(Error::from)
RAFT_MESSAGE_RECV_COUNTER.inc();
future::result(ch.send_raft_msg(msg)).map_err(Error::from)

This comment has been minimized.

@overvenus

overvenus Sep 11, 2017

Member

We will not allow region 0 later. So here we need to send an invalid region.

#2244 (comment)

Base on the comment, it should either return an error or end the stream if region id is 0, but here it just ignore.

@overvenus

overvenus Sep 11, 2017

Member

We will not allow region 0 later. So here we need to send an invalid region.

#2244 (comment)

Base on the comment, it should either return an error or end the stream if region id is 0, but here it just ignore.

This comment has been minimized.

@siddontang

siddontang Sep 11, 2017

Contributor

Because we will check the region in raftstore.
Here using 0 is for gRPC buffer hint before, but when we support raftclient flush, we don't need this now.

@siddontang

siddontang Sep 11, 2017

Contributor

Because we will check the region in raftstore.
Here using 0 is for gRPC buffer hint before, but when we support raftclient flush, we don't need this now.

This comment has been minimized.

@overvenus

overvenus Sep 12, 2017

Member

We will not allow region 0 later.

Do you mean server should reject invalid requests?

So here we need to send an invalid region.

Do you mean add a new test for ensuring server rejects invalid requests?
The test already sends invalid requests. 0 is the default value.
https://github.com/pingcap/tikv/pull/2244/files#diff-1f7f5096d9c5dc14c96baa97db5e97b8R456

Because we will check the region in raftstore.

Checks in raftstore will not close the streaming or send an error, so that client does not know if the request, it sends, is vaild or not.

@overvenus

overvenus Sep 12, 2017

Member

We will not allow region 0 later.

Do you mean server should reject invalid requests?

So here we need to send an invalid region.

Do you mean add a new test for ensuring server rejects invalid requests?
The test already sends invalid requests. 0 is the default value.
https://github.com/pingcap/tikv/pull/2244/files#diff-1f7f5096d9c5dc14c96baa97db5e97b8R456

Because we will check the region in raftstore.

Checks in raftstore will not close the streaming or send an error, so that client does not know if the request, it sends, is vaild or not.

This comment has been minimized.

@siddontang

siddontang Sep 12, 2017

Contributor

no need check here now. we can't know the message is valid here.

@siddontang

siddontang Sep 12, 2017

Contributor

no need check here now. we can't know the message is valid here.

@overvenus

LGTM

@disksing disksing merged commit 17b4491 into master Sep 12, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the disksing/grpc branch Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment