New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coprocessor/* : adjust metrics #2280

Merged
merged 8 commits into from Sep 14, 2017

Conversation

Projects
None yet
4 participants
@AndreMouche
Member

AndreMouche commented Sep 11, 2017

hi,
This PR split label dag into select and index_scan in matrics for coprocessor @BusyJay @hicqu PTAL

Show outdated Hide outdated src/coprocessor/dag/dag.rs
Show outdated Hide outdated src/coprocessor/select/select.rs
Show outdated Hide outdated src/coprocessor/select/select.rs
Show outdated Hide outdated src/coprocessor/endpoint.rs
@@ -242,13 +247,19 @@ impl RequestTask {
Err(box_err!(e))
} else {
start_ts = Some(dag.get_start_ts());
if let Some(scan) = dag.get_executors().iter().next() {

This comment has been minimized.

@BusyJay

BusyJay Sep 12, 2017

Contributor

The first node is always scan?

@BusyJay

BusyJay Sep 12, 2017

Contributor

The first node is always scan?

This comment has been minimized.

@AndreMouche
@AndreMouche
Show outdated Hide outdated src/coprocessor/mod.rs
Show outdated Hide outdated src/coprocessor/endpoint.rs
@BusyJay

LGTM, /run-all-tests

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche
Member

AndreMouche commented Sep 14, 2017

for (tag, count) in details {
COPR_SCAN_DETAILS
.with_label_values(&[type_str, cf, tag])
.observe(count as f64 / task_count as f64);
.observe(count as f64 / this_statistics.count as f64);

This comment has been minimized.

@siddontang

siddontang Sep 14, 2017

Contributor

I don't know exactly what is the metric COPR_SCAN_DETAILS used for, and why do we need to use divide the count here. Can you give me a metric example?

@siddontang

siddontang Sep 14, 2017

Contributor

I don't know exactly what is the metric COPR_SCAN_DETAILS used for, and why do we need to use divide the count here. Can you give me a metric example?

This comment has been minimized.

@AndreMouche

AndreMouche Sep 14, 2017

Member

We will implement LocalHistogramVec and use it instead later @siddontang

@AndreMouche

AndreMouche Sep 14, 2017

Member

We will implement LocalHistogramVec and use it instead later @siddontang

This comment has been minimized.

@siddontang

siddontang Sep 14, 2017

Contributor

Got it

@siddontang

siddontang Sep 14, 2017

Contributor

Got it

@ngaut

ngaut approved these changes Sep 14, 2017

@AndreMouche AndreMouche merged commit c5878ef into master Sep 14, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@AndreMouche AndreMouche deleted the shirly/cop_metrics branch Sep 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment