New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: remove stale peer as soon as possible #2281

Merged
merged 5 commits into from Sep 13, 2017
Jump to file or symbol
Failed to load files and symbols.
+1 −0
Diff settings

Always

Just for now

Viewing a subset of changes. View all

address comment

  • Loading branch information...
BusyJay committed Sep 11, 2017
commit 789b6bbf809d662abcc37fcf0ead70f9bdf21028
@@ -1174,6 +1174,7 @@ impl<T: Transport, C: PdClient> Store<T, C> {
Some(p) => if p.peer_id() == peer.get_id() {
p
} else {
assert!(p.peer_id() > peer.get_id());

This comment has been minimized.

@siddontang

siddontang Sep 12, 2017

Contributor

add a comment for how can we meet this case.

@siddontang

siddontang Sep 12, 2017

Contributor

add a comment for how can we meet this case.

// It has been destroyed.

This comment has been minimized.

@siddontang

siddontang Sep 11, 2017

Contributor

need to check p.peer_id() must > peer.get_id() here?

@siddontang

siddontang Sep 11, 2017

Contributor

need to check p.peer_id() must > peer.get_id() here?

self.region_peers.insert(region_id, p);
return;
ProTip! Use n and p to navigate between commits in a pull request.