New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add SplitRegion API #2287

Merged
merged 21 commits into from Sep 22, 2017

Conversation

Projects
None yet
7 participants
@overvenus
Member

overvenus commented Sep 13, 2017

@overvenus overvenus referenced this pull request Sep 13, 2017

Merged

Add SplitRegion API #191

@@ -67,9 +67,16 @@ pub enum Msg {
SplitCheckResult {
region_id: u64,
epoch: RegionEpoch,
// It's a data key, starts with `DATA_PREFIX_KEY`.

This comment has been minimized.

@siddontang

siddontang Sep 17, 2017

Contributor

We may support meta key later.

@siddontang

siddontang Sep 17, 2017

Contributor

We may support meta key later.

This comment has been minimized.

@lishuai87

lishuai87 Sep 20, 2017

Contributor

can be same type with SplitRegion.split_key

@lishuai87

lishuai87 Sep 20, 2017

Contributor

can be same type with SplitRegion.split_key

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus
Member

overvenus commented Sep 19, 2017

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Sep 19, 2017

Member

PTAL

Member

overvenus commented Sep 19, 2017

PTAL

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 19, 2017

Contributor

LGTM

PTAL @BusyJay @javaforfun

Contributor

siddontang commented Sep 19, 2017

LGTM

PTAL @BusyJay @javaforfun

Show outdated Hide outdated src/raftstore/store/store.rs
Show outdated Hide outdated src/raftstore/store/store.rs
Show outdated Hide outdated src/raftstore/store/store.rs
Show outdated Hide outdated src/raftstore/store/store.rs
Show outdated Hide outdated tests/raftstore/test_split_region.rs
self.on_prepare_split_region(
region_id,
epoch,
keys::origin_key(split_key.as_slice()).to_vec(),

This comment has been minimized.

@lishuai87

lishuai87 Sep 20, 2017

Contributor

pd AskSplit use different split_key type now?

@lishuai87

lishuai87 Sep 20, 2017

Contributor

pd AskSplit use different split_key type now?

This comment has been minimized.

@overvenus

overvenus Sep 20, 2017

Member

Actully the split_key here is a data key, AskSplit requires encoded key, so convert it by keys::origin_key.

@overvenus

overvenus Sep 20, 2017

Member

Actully the split_key here is a data key, AskSplit requires encoded key, so convert it by keys::origin_key.

@lishuai87

This comment has been minimized.

Show comment
Hide comment
@lishuai87

lishuai87 Sep 20, 2017

Contributor

rest lgtm

Contributor

lishuai87 commented Sep 20, 2017

rest lgtm

overvenus added some commits Sep 20, 2017

Show outdated Hide outdated src/raftstore/store/store.rs
Show outdated Hide outdated tests/raftstore/cluster.rs
Show outdated Hide outdated tests/raftstore/test_split_region.rs
Show outdated Hide outdated tests/raftstore/test_split_region.rs
@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Sep 20, 2017

Collaborator

/rebuild

Collaborator

iamxy commented Sep 20, 2017

/rebuild

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 21, 2017

Contributor

Any update?

Contributor

siddontang commented Sep 21, 2017

Any update?

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Sep 21, 2017

Member

PTAL

Member

overvenus commented Sep 21, 2017

PTAL

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 21, 2017

Contributor

LGTM

Contributor

BusyJay commented Sep 21, 2017

LGTM

overvenus added some commits Sep 21, 2017

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Sep 21, 2017

Member

/run-all-test

Member

overvenus commented Sep 21, 2017

/run-all-test

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Sep 21, 2017

Member

/run-integration-ddl-test
/run-unit-test

Member

overvenus commented Sep 21, 2017

/run-integration-ddl-test
/run-unit-test

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Sep 21, 2017

Member

/run-unit-test

Member

overvenus commented Sep 21, 2017

/run-unit-test

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Sep 21, 2017

Member

/run-all-test

Member

overvenus commented Sep 21, 2017

/run-all-test

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Sep 21, 2017

Collaborator

/run-all-test

Collaborator

iamxy commented Sep 21, 2017

/run-all-test

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Sep 22, 2017

Member

/run-all-test

Member

overvenus commented Sep 22, 2017

/run-all-test

@overvenus overvenus merged commit 797b3a3 into master Sep 22, 2017

5 of 6 checks passed

jenkins-ci-tikv/unit-test Jenkins job failed
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@overvenus overvenus deleted the ov/region-split branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment