New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin level0 filter and index blocks #2288

Merged
merged 2 commits into from Sep 13, 2017

Conversation

Projects
None yet
3 participants
@zhangjinpeng1987
Member

zhangjinpeng1987 commented Sep 13, 2017

No description provided.

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 13, 2017

Contributor

Do we need to support optimize_filters_for_hits for default CF too?

Contributor

siddontang commented Sep 13, 2017

Do we need to support optimize_filters_for_hits for default CF too?

@zhangjinpeng1987

This comment has been minimized.

Show comment
Hide comment
@zhangjinpeng1987

zhangjinpeng1987 Sep 13, 2017

Member

Default cf is included.

Member

zhangjinpeng1987 commented Sep 13, 2017

Default cf is included.

@siddontang

LGTM

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Contributor

siddontang commented Sep 13, 2017

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 13, 2017

Contributor

Default cf is included.

I can't find it. @zhangjinpeng1987

Contributor

siddontang commented Sep 13, 2017

Default cf is included.

I can't find it. @zhangjinpeng1987

@huachaohuang

LGTM

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 13, 2017

Contributor

CI failed

Contributor

siddontang commented Sep 13, 2017

CI failed

@zhangjinpeng1987 zhangjinpeng1987 merged commit b67b69a into master Sep 13, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zhangjinpeng1987 zhangjinpeng1987 deleted the zhangjinpeng/pin-level0-filter-index branch Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment