New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sync_log for kv_rpc_request #2289

Merged
merged 8 commits into from Sep 22, 2017

Conversation

Projects
None yet
4 participants
@lishuai87
Contributor

lishuai87 commented Sep 13, 2017

Fixes #2271

@zhangjinpeng1987

This comment has been minimized.

Show comment
Hide comment
@zhangjinpeng1987
Member

zhangjinpeng1987 commented Sep 15, 2017

LGTM

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Contributor

siddontang commented Sep 15, 2017

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 17, 2017

Contributor

LGTM

PTAL @BusyJay

Contributor

siddontang commented Sep 17, 2017

LGTM

PTAL @BusyJay

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 19, 2017

Contributor

PTAL @BusyJay

Contributor

siddontang commented Sep 19, 2017

PTAL @BusyJay

Show outdated Hide outdated src/raftstore/store/peer.rs
Show outdated Hide outdated src/raftstore/store/peer.rs
Show outdated Hide outdated tests/raft/test_raft.rs
@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 21, 2017

Contributor

Please fix the conflict @javaforfun

Contributor

siddontang commented Sep 21, 2017

Please fix the conflict @javaforfun

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 21, 2017

Contributor

LGTM

Contributor

BusyJay commented Sep 21, 2017

LGTM

@lishuai87

This comment has been minimized.

Show comment
Hide comment
@lishuai87

lishuai87 Sep 21, 2017

Contributor

need merge pingcap/kvproto#192 first

Contributor

lishuai87 commented Sep 21, 2017

need merge pingcap/kvproto#192 first

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 22, 2017

Contributor

@javaforfun

You can fix the conflict and merge now.

Contributor

siddontang commented Sep 22, 2017

@javaforfun

You can fix the conflict and merge now.

@lishuai87

This comment has been minimized.

Show comment
Hide comment
@lishuai87

lishuai87 Sep 22, 2017

Contributor

need merge #2287 first, kvproto tikvpb_grpc added a new method, but tikv master don't have.

Contributor

lishuai87 commented Sep 22, 2017

need merge #2287 first, kvproto tikvpb_grpc added a new method, but tikv master don't have.

@siddontang siddontang merged commit 216610b into master Sep 22, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@siddontang siddontang deleted the javaforfun/force-sync branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment