New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/*: implement metrics for scan details in scheduler #2291

Merged
merged 5 commits into from Sep 15, 2017

Conversation

Projects
None yet
4 participants
@AndreMouche
Member

AndreMouche commented Sep 14, 2017

@jackysp jackysp changed the title from storage/*: implement matrics for scan details in scheduler to storage/*: implement matrix for scan details in scheduler Sep 14, 2017

@jackysp jackysp changed the title from storage/*: implement matrix for scan details in scheduler to storage/*: implement metrics for scan details in scheduler Sep 14, 2017

impl ThreadContext for ScheContext {
fn on_tick(&mut self) {
for (cmd, stat) in self.stats.drain() {

This comment has been minimized.

@siddontang

siddontang Sep 14, 2017

Contributor

too many for here, any way to optimize it? /cc @BusyJay

@siddontang

siddontang Sep 14, 2017

Contributor

too many for here, any way to optimize it? /cc @BusyJay

This comment has been minimized.

@BusyJay

BusyJay Sep 14, 2017

Contributor

There is not built-in cube support in iterator.

@BusyJay

BusyJay Sep 14, 2017

Contributor

There is not built-in cube support in iterator.

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 15, 2017

Contributor

LGTM

Please update the grafana too.

Contributor

siddontang commented Sep 15, 2017

LGTM

Please update the grafana too.

@disksing

LGTM

@AndreMouche AndreMouche merged commit a84d343 into master Sep 15, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@AndreMouche AndreMouche deleted the shirly/scheduler_metrics branch Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment