New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expr/builtin_cast: fix bug in cast_str_as_int #2296

Merged
merged 5 commits into from Sep 15, 2017

Conversation

Projects
None yet
3 participants
@AndreMouche
Member

AndreMouche commented Sep 14, 2017

@BusyJay

LGTM, /run-all-tests

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche
Member

AndreMouche commented Sep 15, 2017

@hicqu PTAL

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 15, 2017

Contributor

LGTM.

Contributor

hicqu commented Sep 15, 2017

LGTM.

@hicqu

hicqu approved these changes Sep 15, 2017

@AndreMouche AndreMouche merged commit 3ef9f38 into master Sep 15, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@AndreMouche AndreMouche deleted the shirly/cast_str_as_int branch Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment