New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics for compression ratio at different levels #2297

Merged
merged 2 commits into from Sep 15, 2017

Conversation

Projects
None yet
3 participants
@huachaohuang
Member

huachaohuang commented Sep 15, 2017

No description provided.

@lishuai87

This comment has been minimized.

Show comment
Hide comment
@lishuai87

lishuai87 Sep 15, 2017

Contributor

LGTM

Contributor

lishuai87 commented Sep 15, 2017

LGTM

// Compression ratio at levels
let opts = engine.get_options_cf(handle);
for level in 0..opts.get_num_levels() {

This comment has been minimized.

@zhangjinpeng1987

zhangjinpeng1987 Sep 15, 2017

Member

Some levels maybe empty, is it ok?

@zhangjinpeng1987

zhangjinpeng1987 Sep 15, 2017

Member

Some levels maybe empty, is it ok?

This comment has been minimized.

@huachaohuang

huachaohuang Sep 15, 2017

Member

Yep, the compression ratio of an empty level will be -1.0.

@huachaohuang

huachaohuang Sep 15, 2017

Member

Yep, the compression ratio of an empty level will be -1.0.

@zhangjinpeng1987

This comment has been minimized.

Show comment
Hide comment
@zhangjinpeng1987
Member

zhangjinpeng1987 commented Sep 15, 2017

LGTM

@huachaohuang huachaohuang merged commit b9024bc into master Sep 15, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@huachaohuang huachaohuang deleted the huachao/compression-ratio branch Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment