New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove opp_neg #2301

Merged
merged 2 commits into from Sep 18, 2017

Conversation

Projects
None yet
3 participants
@BusyJay
Contributor

BusyJay commented Sep 15, 2017

From rust 1.7, overflowing_neg is supported, so we don't need opp_neg anymore.

@BusyJay BusyJay requested review from siddontang, AndreMouche and hicqu Sep 15, 2017

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 15, 2017

Contributor

LGTM.

Contributor

hicqu commented Sep 15, 2017

LGTM.

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 18, 2017

Contributor

ping

Contributor

BusyJay commented Sep 18, 2017

ping

@AndreMouche

LGTM

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 18, 2017

Contributor

/run-integration-test

Contributor

BusyJay commented Sep 18, 2017

/run-integration-test

@BusyJay BusyJay merged commit 3a9c68c into master Sep 18, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@BusyJay BusyJay deleted the busyjay/remove-opp-neg branch Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment