New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: enhance sync_log #2308

Merged
merged 2 commits into from Sep 19, 2017

Conversation

Projects
None yet
3 participants
@lishuai87
Contributor

lishuai87 commented Sep 18, 2017

so now we have two rocksdb, we have two WAL.

raftsotre.sync-log = true means we need prevent data loss when power failure.
take raft log gc for example, we write kv WAL first, then write raft WAL,
if power failure happen, raft WAL may synced to disk, but kv WAL may not.
so we use sync-log flag here.
@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 18, 2017

Contributor

LGTM
PTAL @BusyJay

Contributor

siddontang commented Sep 18, 2017

LGTM
PTAL @BusyJay

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 18, 2017

Contributor

LGTM, /run-integration-tests

Contributor

BusyJay commented Sep 18, 2017

LGTM, /run-integration-tests

@lishuai87 lishuai87 merged commit 805630b into master Sep 19, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@lishuai87 lishuai87 deleted the javaforfun/enhance-sync-log branch Sep 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment