New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/*: add metrics for txn #2312

Merged
merged 3 commits into from Sep 20, 2017

Conversation

Projects
None yet
3 participants
@AndreMouche
Member

AndreMouche commented Sep 18, 2017

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 18, 2017

Contributor

I think we should use local metrics and then flush to global later.

Contributor

siddontang commented Sep 18, 2017

I think we should use local metrics and then flush to global later.

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 18, 2017

Contributor

LGTM

Contributor

disksing commented Sep 18, 2017

LGTM

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche
Member

AndreMouche commented Sep 19, 2017

@siddontang

LGTM

@AndreMouche AndreMouche merged commit f9244e0 into master Sep 20, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@AndreMouche AndreMouche deleted the shirly/txn_metrics branch Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment