New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: add drop message metrics #2316

Merged
merged 7 commits into from Sep 26, 2017

Conversation

Projects
None yet
3 participants
@overvenus
Member

overvenus commented Sep 19, 2017

Records dropped raft messages. Please let me know if I am missing something.

@overvenus overvenus requested review from siddontang and BusyJay Sep 19, 2017

@siddontang

Rest LGTM

PTAL @BusyJay

Address comments
Add a new metrics for recording dropped messages
@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Sep 20, 2017

Member

PTAL

Member

overvenus commented Sep 20, 2017

PTAL

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 21, 2017

Contributor

PTAL @javaforfun

Contributor

siddontang commented Sep 21, 2017

PTAL @javaforfun

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 22, 2017

Contributor

No need, here we just want to know the invalid message like stale, mismatched store ID, dropping.

Contributor

siddontang commented Sep 22, 2017

No need, here we just want to know the invalid message like stale, mismatched store ID, dropping.

@BusyJay

check_msg and check_snapshot is not covered.

Show outdated Hide outdated src/raftstore/store/store.rs Outdated
@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Sep 26, 2017

Member

PTAL

Member

overvenus commented Sep 26, 2017

PTAL

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 26, 2017

Contributor

LGTM

Contributor

BusyJay commented Sep 26, 2017

LGTM

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Sep 26, 2017

Member

/run-all-test

Member

overvenus commented Sep 26, 2017

/run-all-test

@overvenus overvenus merged commit 88730a3 into master Sep 26, 2017

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tikv/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@overvenus overvenus deleted the ov/drop-raft-msg branch Sep 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment