New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benches: fix resource download and extract. #2321

Merged
merged 15 commits into from Sep 22, 2017

Conversation

Projects
None yet
5 participants
@hicqu
Contributor

hicqu commented Sep 20, 2017

No description provided.

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 20, 2017

Contributor
Contributor

hicqu commented Sep 20, 2017

@hicqu hicqu requested review from AndreMouche and BusyJay Sep 20, 2017

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche

AndreMouche Sep 20, 2017

Member

/run-all-tests

Member

AndreMouche commented Sep 20, 2017

/run-all-tests

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 20, 2017

Contributor

/run-all-tests

Contributor

hicqu commented Sep 20, 2017

/run-all-tests

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 20, 2017

Contributor

/run-all-tests

Contributor

hicqu commented Sep 20, 2017

/run-all-tests

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Sep 20, 2017

Collaborator

/rebuild

Collaborator

iamxy commented Sep 20, 2017

/rebuild

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche

AndreMouche Sep 21, 2017

Member

/run-all-tests

Member

AndreMouche commented Sep 21, 2017

/run-all-tests

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 21, 2017

Contributor

/run-all-tests

Contributor

hicqu commented Sep 21, 2017

/run-all-tests

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 21, 2017

Contributor

/run-all-tests

Contributor

hicqu commented Sep 21, 2017

/run-all-tests

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 21, 2017

Contributor

@BusyJay , PTAL, thanks.

Contributor

hicqu commented Sep 21, 2017

@BusyJay , PTAL, thanks.

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 21, 2017

Contributor

/run-all-tests

Contributor

hicqu commented Sep 21, 2017

/run-all-tests

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 21, 2017

Contributor

/run-all-tests

Contributor

hicqu commented Sep 21, 2017

/run-all-tests

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Sep 21, 2017

Collaborator

/rebuild

Collaborator

iamxy commented Sep 21, 2017

/rebuild

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 21, 2017

Contributor

Let's add a #[ignore] to the test cases for now. We generally only want to bench it rather than test it.

Contributor

BusyJay commented Sep 21, 2017

Let's add a #[ignore] to the test cases for now. We generally only want to bench it rather than test it.

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 22, 2017

Contributor

Now we can use cargo bench --features "default" -- --nocapture --ignored to run those benches.

Contributor

hicqu commented Sep 22, 2017

Now we can use cargo bench --features "default" -- --nocapture --ignored to run those benches.

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 22, 2017

Contributor

/run-all-tests

Contributor

hicqu commented Sep 22, 2017

/run-all-tests

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 22, 2017

Contributor

LGTM

Contributor

BusyJay commented Sep 22, 2017

LGTM

@overvenus

LGTM

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Sep 22, 2017

Member

/run-all-test

Member

overvenus commented Sep 22, 2017

/run-all-test

@AndreMouche AndreMouche merged commit b7b6f46 into master Sep 22, 2017

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tikv/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@AndreMouche AndreMouche deleted the qupeng/fix-bench-unzip branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment