New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply: update slow log place #2333

Merged
merged 4 commits into from Sep 26, 2017

Conversation

Projects
None yet
3 participants
@siddontang
Contributor

siddontang commented Sep 25, 2017

Use slow log after writing a batch.

PTAL @BusyJay @javaforfun @overvenus

@@ -1449,14 +1442,16 @@ impl Runner {
delegates: delegates,
notifier: notifier,
sync_log: sync_log,
tag: format!("[store {}]", store.store_id()),

This comment has been minimized.

@overvenus

overvenus Sep 25, 2017

Member

Could you aviod allocation here ?

@overvenus

overvenus Sep 25, 2017

Member

Could you aviod allocation here ?

This comment has been minimized.

@siddontang

siddontang Sep 25, 2017

Contributor

There is only one allocation, no need to optimize.

@siddontang

siddontang Sep 25, 2017

Contributor

There is only one allocation, no need to optimize.

@lishuai87

This comment has been minimized.

Show comment
Hide comment
@lishuai87

lishuai87 Sep 25, 2017

Contributor

LGTM

Contributor

lishuai87 commented Sep 25, 2017

LGTM

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 25, 2017

Contributor

PTAL @BusyJay

Contributor

siddontang commented Sep 25, 2017

PTAL @BusyJay

@overvenus

LGTM

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Sep 26, 2017

Member

/run-all-test

Member

overvenus commented Sep 26, 2017

/run-all-test

@siddontang siddontang merged commit 63be25d into master Sep 26, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@siddontang siddontang deleted the siddontang/apply-slow-log branch Sep 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment