New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First set of changes in support of ppc64le #2334

Merged
merged 8 commits into from Sep 28, 2017

Conversation

Projects
None yet
5 participants
@seth-priya
Contributor

seth-priya commented Sep 25, 2017

Upgrading version of some of the dependencies that do not work on ppc64le.

These changes have been tested on Intel (x86_64) architecture using "cargo build" and "cargo test".

The next set of changes are specific to incrementing the version of mio and changes required in support of that.

@sre-bot

This comment has been minimized.

Show comment
Hide comment
@sre-bot

sre-bot Sep 25, 2017

Collaborator

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

Collaborator

sre-bot commented Sep 25, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Sep 25, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Sep 25, 2017

CLA assistant check
All committers have signed the CLA.

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 25, 2017

Contributor

Thanks @seth-priya

Please sign the CLA.

Contributor

siddontang commented Sep 25, 2017

Thanks @seth-priya

Please sign the CLA.

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 25, 2017

Contributor

LGTM

Contributor

siddontang commented Sep 25, 2017

LGTM

@@ -65,7 +65,7 @@ mod imp {
for sig in trap {
match sig {
SIGTERM | SIGINT | SIGHUP => {
info!("receive signal {}, stopping server...", sig);
info!("receive signal {}, stopping server...", sig as c_int);

This comment has been minimized.

@BusyJay

BusyJay Sep 25, 2017

Contributor

Why cast is required here?

@BusyJay

BusyJay Sep 25, 2017

Contributor

Why cast is required here?

This comment has been minimized.

@seth-priya

seth-priya Sep 26, 2017

Contributor

This is required because of the signal version upgrade from 1.2 to 1.4 and the changes that went into it to upgrade nix

@seth-priya

seth-priya Sep 26, 2017

Contributor

This is required because of the signal version upgrade from 1.2 to 1.4 and the changes that went into it to upgrade nix

Show outdated Hide outdated Cargo.lock
@seth-priya

This comment has been minimized.

Show comment
Hide comment
@seth-priya

seth-priya Sep 26, 2017

Contributor

@BusyJay @siddontang - Thanks for your review and quick feedback!
Please let me know if there are any further queries.

I am working on the circleci failure (looks like a format error) and am also reviewing the terms of the CLA (I had missed that earlier as I could not find a reference to it here - https://github.com/pingcap/tikv/blob/master/CONTRIBUTING.md

I will get back on this as soon as possible! Thanks!

Contributor

seth-priya commented Sep 26, 2017

@BusyJay @siddontang - Thanks for your review and quick feedback!
Please let me know if there are any further queries.

I am working on the circleci failure (looks like a format error) and am also reviewing the terms of the CLA (I had missed that earlier as I could not find a reference to it here - https://github.com/pingcap/tikv/blob/master/CONTRIBUTING.md

I will get back on this as soon as possible! Thanks!

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 26, 2017

Contributor

@seth-priya

Seem you can use make format to format the code. Be sure to install rustfmt cargo install --vers 0.2.1 --force rustfmt-nightly at first.

Contributor

siddontang commented Sep 26, 2017

@seth-priya

Seem you can use make format to format the code. Be sure to install rustfmt cargo install --vers 0.2.1 --force rustfmt-nightly at first.

@seth-priya

This comment has been minimized.

Show comment
Hide comment
@seth-priya

seth-priya Sep 26, 2017

Contributor

@siddontang sure will try that and retest - thanks!

Contributor

seth-priya commented Sep 26, 2017

@siddontang sure will try that and retest - thanks!

@seth-priya

This comment has been minimized.

Show comment
Hide comment
@seth-priya

seth-priya Sep 27, 2017

Contributor

CLA signed and circleci fixed.

Contributor

seth-priya commented Sep 27, 2017

CLA signed and circleci fixed.

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 27, 2017

Contributor

LGTM, /run-integration-tests

Contributor

BusyJay commented Sep 27, 2017

LGTM, /run-integration-tests

@seth-priya

This comment has been minimized.

Show comment
Hide comment
@seth-priya

seth-priya Sep 28, 2017

Contributor

@BusyJay is there a way to run integration tests locally? I am not sure if I am able to understand the real issue from the logs here http://45.249.247.133:8080/blue/organizations/jenkins/tikv_ghpr_integration_ddl_test/detail/tikv_ghpr_integration_ddl_test/87/pipeline
Thanks!

Contributor

seth-priya commented Sep 28, 2017

@BusyJay is there a way to run integration tests locally? I am not sure if I am able to understand the real issue from the logs here http://45.249.247.133:8080/blue/organizations/jenkins/tikv_ghpr_integration_ddl_test/detail/tikv_ghpr_integration_ddl_test/87/pipeline
Thanks!

@siddontang

LGTM

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 28, 2017

Contributor

Thanks @seth-priya

Contributor

siddontang commented Sep 28, 2017

Thanks @seth-priya

@siddontang siddontang merged commit 12f8a90 into tikv:master Sep 28, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment