New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: add scan_mvcc support. #2335

Merged
merged 37 commits into from Oct 12, 2017

Conversation

Projects
None yet
4 participants
@hicqu
Contributor

hicqu commented Sep 25, 2017

This PR add support for debug ScanMvcc API.

@hicqu hicqu requested a review from overvenus Sep 25, 2017

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 25, 2017

Contributor

@overvenus , PTAL, thanks.

Contributor

hicqu commented Sep 25, 2017

@overvenus , PTAL, thanks.

Show outdated Hide outdated src/server/service/debug.rs
Show outdated Hide outdated src/raftstore/store/debug.rs
Show outdated Hide outdated src/raftstore/store/debug.rs
Show outdated Hide outdated src/server/service/debug.rs
Show outdated Hide outdated src/server/service/debug.rs
Show outdated Hide outdated src/raftstore/store/debug.rs
Show outdated Hide outdated src/raftstore/store/debug.rs
Show outdated Hide outdated src/raftstore/store/debug.rs
@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 27, 2017

Contributor

@overvenus , Now we don't need useless MvccKVDealer trait. PTAL again, thanks.

Contributor

hicqu commented Sep 27, 2017

@overvenus , Now we don't need useless MvccKVDealer trait. PTAL again, thanks.

@hicqu hicqu requested review from BusyJay and overvenus Sep 27, 2017

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 27, 2017

Contributor

@BusyJay , PTAL, thanks.

Contributor

hicqu commented Sep 27, 2017

@BusyJay , PTAL, thanks.

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Contributor

siddontang commented Sep 28, 2017

hicqu added some commits Sep 28, 2017

Show outdated Hide outdated src/raftstore/store/debug.rs
Show outdated Hide outdated src/raftstore/store/debug.rs
Show outdated Hide outdated src/raftstore/store/debug.rs
Show outdated Hide outdated src/raftstore/store/debug.rs
Show outdated Hide outdated src/raftstore/store/debug.rs
Show outdated Hide outdated src/raftstore/store/debug.rs

hicqu added some commits Sep 28, 2017

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 29, 2017

Contributor

/run-all-test

Contributor

hicqu commented Sep 29, 2017

/run-all-test

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 29, 2017

Contributor

@BusyJay , PTAL, thanks.

Contributor

hicqu commented Sep 29, 2017

@BusyJay , PTAL, thanks.

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Oct 5, 2017

Contributor

@BusyJay PTAL thanks.

Contributor

hicqu commented Oct 5, 2017

@BusyJay PTAL thanks.

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Oct 9, 2017

Contributor

PTAL @BusyJay

Contributor

siddontang commented Oct 9, 2017

PTAL @BusyJay

Show outdated Hide outdated src/raftstore/store/debug.rs
Show outdated Hide outdated src/server/service/debug.rs
Show outdated Hide outdated src/server/service/debug.rs
@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Oct 11, 2017

Contributor

@BusyJay , PTAL thanks.

Contributor

hicqu commented Oct 11, 2017

@BusyJay , PTAL thanks.

hicqu added some commits Oct 11, 2017

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Oct 11, 2017

Contributor

@BusyJay , PTAL, thanks.

Contributor

hicqu commented Oct 11, 2017

@BusyJay , PTAL, thanks.

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Oct 11, 2017

Contributor

LGTM, though I think MvccInfoIterator can still be improved.

Contributor

BusyJay commented Oct 11, 2017

LGTM, though I think MvccInfoIterator can still be improved.

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Oct 11, 2017

Contributor

/run-integration-tests

Contributor

BusyJay commented Oct 11, 2017

/run-integration-tests

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Contributor

siddontang commented Oct 11, 2017

PTAL @overvenus

Show outdated Hide outdated src/raftstore/store/debug.rs
Show outdated Hide outdated src/raftstore/store/keys.rs
@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Oct 12, 2017

Contributor

@overvenus , PTAL again, thanks.

Contributor

hicqu commented Oct 12, 2017

@overvenus , PTAL again, thanks.

},
Ordering::Greater => {}
_ => {
let err_msg = format!(

This comment has been minimized.

@BusyJay

BusyJay Oct 12, 2017

Contributor

/cc @disksing, is an error message or listing all the related kvs better help with debuging?

@BusyJay

BusyJay Oct 12, 2017

Contributor

/cc @disksing, is an error message or listing all the related kvs better help with debuging?

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Oct 12, 2017

Member

/run-all-test

Member

overvenus commented Oct 12, 2017

/run-all-test

@hicqu hicqu merged commit 464c161 into master Oct 12, 2017

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tikv/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hicqu hicqu deleted the qupeng/debug-scan-mvcc branch Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment