New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gRPC to 1.6.1 #2336

Merged
merged 2 commits into from Sep 26, 2017

Conversation

Projects
None yet
4 participants
@BusyJay
Contributor

BusyJay commented Sep 25, 2017

gRPC handles connection internally, so different channels may share the same TCP connection under the hook. But we attempts to maintain the connection by ourselves. I tried to utilize the gRPC implementation but get some wired behavior. I may investigate it further, but let's keep compatible with the old behavior first.

There is no big performance difference in sysbench and pure kv bench after being upgraded, though pure gRPC bench shows a little performance increase in single connection mode.

@BusyJay BusyJay requested review from siddontang, overvenus and disksing Sep 25, 2017

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 25, 2017

Contributor

LGTM

Contributor

siddontang commented Sep 25, 2017

LGTM

@disksing

LGTM.

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Sep 26, 2017

Member

/run-all-test

Member

overvenus commented Sep 26, 2017

/run-all-test

@BusyJay BusyJay merged commit 92949d0 into master Sep 26, 2017

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tikv/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@BusyJay BusyJay deleted the busyjay/update-grpc branch Sep 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment