New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: directly report statistics to pd #2337

Merged
merged 22 commits into from Oct 13, 2017

Conversation

Projects
None yet
4 participants
@nolouch
Contributor

nolouch commented Sep 25, 2017

refactor coprocessor and report statistics to pd worker

@nolouch nolouch changed the title from *: move out pd work from raftstore to [WIP] *: move out pd work from raftstore Sep 26, 2017

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 27, 2017

Contributor

PTAL @BusyJay

Contributor

siddontang commented Sep 27, 2017

PTAL @BusyJay

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 30, 2017

Contributor

Any update @nolouch

Contributor

siddontang commented Sep 30, 2017

Any update @nolouch

nolouch added some commits Sep 30, 2017

@nolouch nolouch changed the title from [WIP] *: move out pd work from raftstore to *: move out pd work from raftstore Oct 8, 2017

Show outdated Hide outdated src/pd/pd.rs
Show outdated Hide outdated src/pd/pd.rs
@@ -63,14 +64,14 @@ const OUTDATED_ERROR_MSG: &'static str = "request outdated.";
const ENDPOINT_IS_BUSY: &'static str = "endpoint is busy";
pub struct Host<R: CopSender + 'static> {
pub struct Host {

This comment has been minimized.

@siddontang

siddontang Oct 9, 2017

Contributor

use another PR for refactoring coprocessor.

@siddontang

siddontang Oct 9, 2017

Contributor

use another PR for refactoring coprocessor.

@@ -800,7 +792,8 @@ mod tests {
let engine = engine::new_local_engine(TEMP_DIR, &[]).unwrap();
let mut cfg = Config::default();
cfg.end_point_concurrency = 1;
let mut end_point = Host::new(engine, worker.scheduler(), &cfg, MockCopSender::new());
let pd_worker = FutureWorker::new("test-pd-worker");

This comment has been minimized.

@siddontang

siddontang Oct 9, 2017

Contributor

how to check we have already sent the read statistics?

@siddontang

siddontang Oct 9, 2017

Contributor

how to check we have already sent the read statistics?

This comment has been minimized.

@nolouch

nolouch Oct 9, 2017

Contributor

maybe mock a pd runner?

@nolouch

nolouch Oct 9, 2017

Contributor

maybe mock a pd runner?

This comment has been minimized.

@siddontang

siddontang Oct 10, 2017

Contributor

seem no need now.

@siddontang

siddontang Oct 10, 2017

Contributor

seem no need now.

@nolouch nolouch changed the title from *: move out pd work from raftstore to *: directly report statistics to pd Oct 9, 2017

nolouch added some commits Oct 9, 2017

nolouch added some commits Oct 10, 2017

Show outdated Hide outdated src/pd/pd.rs
@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Oct 11, 2017

Contributor

Any update @nolouch

Contributor

siddontang commented Oct 11, 2017

Any update @nolouch

nolouch added some commits Oct 11, 2017

Show outdated Hide outdated Cargo.toml

nolouch added some commits Oct 11, 2017

nolouch added some commits Oct 12, 2017

@nolouch

This comment has been minimized.

Show comment
Hide comment
@nolouch

nolouch Oct 12, 2017

Contributor

PTAL

Contributor

nolouch commented Oct 12, 2017

PTAL

Show outdated Hide outdated src/pd/pd.rs
@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Contributor

siddontang commented Oct 12, 2017

@@ -114,6 +157,8 @@ pub struct Runner<T: PdClient> {
pd_client: Arc<T>,
ch: SendCh<Msg>,
db: Arc<DB>,
region_peers: HashMap<u64, PeerStat>,

This comment has been minimized.

@zhangjinpeng1987

zhangjinpeng1987 Oct 13, 2017

Member

When a peer is dropped in raftstore, here should keep updated.

@zhangjinpeng1987

zhangjinpeng1987 Oct 13, 2017

Member

When a peer is dropped in raftstore, here should keep updated.

@nolouch nolouch merged commit 18beaa3 into master Oct 13, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@nolouch nolouch deleted the shuning/extract-pd-work branch Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment