New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix potential unreachable drop #2343

Merged
merged 4 commits into from Oct 1, 2017

Conversation

Projects
None yet
3 participants
@BusyJay
Contributor

BusyJay commented Sep 26, 2017

Unreachable report can be ignored if channel is full, which may lead to abandoned follower. This pr unifies Unreachable and SnapshotStatus as significant message and handle them separately from normal messages.

This is an alternative fix for issue #2341.

@@ -59,7 +59,7 @@ impl<T: RaftStoreRouter, S: StoreAddrResolver + 'static> Server<T, S> {
region_split_size: usize,
storage: Storage,
raft_router: T,
snapshot_status_sender: Sender<SnapshotStatusMsg>,
significant_msg_sender: Sender<SignificantMsg>,

This comment has been minimized.

@siddontang

siddontang Sep 27, 2017

Contributor

can we move the sender to the RaftRouter? I think we can only use raft router to communicate with raft store.

So the RaftRouter trait may add:

fn report_unreachable()
fn report_snapshot_status()
@siddontang

siddontang Sep 27, 2017

Contributor

can we move the sender to the RaftRouter? I think we can only use raft router to communicate with raft store.

So the RaftRouter trait may add:

fn report_unreachable()
fn report_snapshot_status()

This comment has been minimized.

@BusyJay

BusyJay Sep 27, 2017

Contributor

Tried, but got a lot of unrelated changes, maybe in another pr.

@BusyJay

BusyJay Sep 27, 2017

Contributor

Tried, but got a lot of unrelated changes, maybe in another pr.

This comment has been minimized.

@siddontang

siddontang Sep 28, 2017

Contributor

Got it. I think it is worth to do it later.

@siddontang

siddontang Sep 28, 2017

Contributor

Got it. I think it is worth to do it later.

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 28, 2017

Contributor

LGTM

Contributor

siddontang commented Sep 28, 2017

LGTM

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Contributor

siddontang commented Sep 28, 2017

PTAL @overvenus

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 29, 2017

Contributor

PTAL @javaforfun

Contributor

siddontang commented Sep 29, 2017

PTAL @javaforfun

@lishuai87

This comment has been minimized.

Show comment
Hide comment
@lishuai87

lishuai87 Sep 30, 2017

Contributor

LGTM

Contributor

lishuai87 commented Sep 30, 2017

LGTM

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 30, 2017

Contributor

/run-all-tests

Contributor

BusyJay commented Sep 30, 2017

/run-all-tests

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Oct 1, 2017

Contributor

/run-integration-test

Contributor

BusyJay commented Oct 1, 2017

/run-integration-test

@BusyJay BusyJay merged commit 6b919c3 into master Oct 1, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@BusyJay BusyJay deleted the busyjay/msg-drop branch Oct 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment