New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dag/expr: return other error instead of panic when expression is illegal #2347

Merged
merged 5 commits into from Sep 27, 2017

Conversation

Projects
None yet
3 participants
@AndreMouche
Member

AndreMouche commented Sep 27, 2017

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 27, 2017

Contributor

LGTM

Contributor

BusyJay commented Sep 27, 2017

LGTM

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 27, 2017

Contributor

LGTM.

Contributor

hicqu commented Sep 27, 2017

LGTM.

@hicqu

hicqu approved these changes Sep 27, 2017

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche

AndreMouche Sep 27, 2017

Member

/run-all-test

Member

AndreMouche commented Sep 27, 2017

/run-all-test

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche

AndreMouche Sep 27, 2017

Member

/run-all-test

Member

AndreMouche commented Sep 27, 2017

/run-all-test

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche

AndreMouche Sep 27, 2017

Member

/run-all-test

Member

AndreMouche commented Sep 27, 2017

/run-all-test

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche

AndreMouche Sep 27, 2017

Member

/run-all-test

Member

AndreMouche commented Sep 27, 2017

/run-all-test

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche

AndreMouche Sep 27, 2017

Member

/run-all-test

Member

AndreMouche commented Sep 27, 2017

/run-all-test

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 27, 2017

Contributor

/run-all-test

Contributor

hicqu commented Sep 27, 2017

/run-all-test

@hicqu hicqu merged commit 3dcb691 into master Sep 27, 2017

5 of 6 checks passed

jenkins-ci-tikv/integration-ddl-test Jenkins job failed
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tikv/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hicqu hicqu deleted the shirly/expr_panic branch Sep 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment