New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support fail points #2354

Merged
merged 30 commits into from Oct 13, 2017

Conversation

Projects
None yet
4 participants
@overvenus
Member

overvenus commented Sep 28, 2017

This PR adds raft fail points and a tool for injecting failures.

CC pingcap/kvproto#200

/// # Examples
///
/// ```sh
/// ./tikv-fail -a 127.0.0.1:9090 inject\

This comment has been minimized.

@siddontang

siddontang Sep 29, 2017

Contributor

can we support a failure list?

@siddontang

siddontang Sep 29, 2017

Contributor

can we support a failure list?

@@ -90,6 +95,9 @@ branch = "dev"
features = ["profiling"]
optional = true
[dependencies.fail]
git = "https://github.com/pingcap/fail-rs.git"

This comment has been minimized.

@BusyJay

BusyJay Sep 29, 2017

Contributor

Why not use crates.io version?

@BusyJay

BusyJay Sep 29, 2017

Contributor

Why not use crates.io version?

Show outdated Hide outdated src/bin/tikv-fail.rs
@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Sep 30, 2017

Member

PTAL

Member

overvenus commented Sep 30, 2017

PTAL

Show outdated Hide outdated src/bin/tikv-fail.rs
Show outdated Hide outdated src/bin/tikv-fail.rs
Show outdated Hide outdated src/bin/tikv-fail.rs
Show outdated Hide outdated src/bin/tikv-fail.rs
Show outdated Hide outdated src/bin/tikv-fail.rs

overvenus added some commits Oct 2, 2017

@BusyJay

Can the configured failpoints be printed out at runtime?

Show outdated Hide outdated src/bin/tikv-fail.rs
Show outdated Hide outdated src/bin/tikv-fail.rs
Show outdated Hide outdated src/bin/tikv-fail.rs

overvenus added some commits Oct 10, 2017

Show outdated Hide outdated Makefile

@overvenus overvenus changed the title from [DNM] *: support fail points to *: support fail points Oct 12, 2017

overvenus added some commits Oct 13, 2017

Show outdated Hide outdated src/bin/tikv-fail.rs
@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Oct 13, 2017

Contributor

LGTM

Contributor

siddontang commented Oct 13, 2017

LGTM

overvenus added some commits Oct 13, 2017

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Oct 13, 2017

Member

/run-all-test

Member

overvenus commented Oct 13, 2017

/run-all-test

@BusyJay

LGTM

@overvenus overvenus merged commit 89002f6 into master Oct 13, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@overvenus overvenus deleted the ov/raft-fail-point branch Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment