New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: move out pd work from raftstore #2361

Merged
merged 3 commits into from Oct 9, 2017

Conversation

Projects
None yet
3 participants
@nolouch
Contributor

nolouch commented Oct 9, 2017

In order to let PD work be able to receive messages from any module, extract it from raftstore. and then I will refactor coprocessor report mechanism in #2337

@nolouch nolouch requested review from siddontang, BusyJay and disksing Oct 9, 2017

@@ -316,6 +319,7 @@ where
Err(box_err!("check cluster bootstrapped failed"))
}
#[allow(too_many_arguments)]

This comment has been minimized.

@siddontang

siddontang Oct 9, 2017

Contributor

I think we must remove this allowance later.

@BusyJay

@siddontang

siddontang Oct 9, 2017

Contributor

I think we must remove this allowance later.

@BusyJay

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Contributor

siddontang commented Oct 9, 2017

@nolouch nolouch requested a review from zhangjinpeng1987 Oct 9, 2017

@huachaohuang

This comment has been minimized.

Show comment
Hide comment
@huachaohuang
Member

huachaohuang commented Oct 9, 2017

LGTM

@siddontang siddontang merged commit 34c4993 into master Oct 9, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@siddontang siddontang deleted the shuning/extract-pd branch Oct 9, 2017

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Oct 9, 2017

Contributor

@huachaohuang

Do we need to update the grafana?

Contributor

siddontang commented Oct 9, 2017

@huachaohuang

Do we need to update the grafana?

@huachaohuang

This comment has been minimized.

Show comment
Hide comment
@huachaohuang

huachaohuang Oct 9, 2017

Member

I'm refactoring the related metrics too, I will update them later.

Member

huachaohuang commented Oct 9, 2017

I'm refactoring the related metrics too, I will update them later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment