New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: move significant send to raft router #2363

Merged
merged 4 commits into from Oct 11, 2017

Conversation

Projects
None yet
3 participants
@siddontang
Contributor

siddontang commented Oct 9, 2017

Now we use raft router and a significant sender to send messages to the raft store, this seems a little duplicated, so here move the significant sender to the raft router, so we can only use the raft router to send messages.

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Contributor

siddontang commented Oct 9, 2017

@siddontang siddontang changed the title from *: move significant send to raft router to [DNM] *: move significant send to raft router Oct 9, 2017

@siddontang siddontang changed the title from [DNM] *: move significant send to raft router to *: move significant send to raft router Oct 10, 2017

Show outdated Hide outdated src/raftstore/store/store.rs Outdated
Show outdated Hide outdated src/server/server.rs Outdated
Show outdated Hide outdated src/server/transport.rs Outdated
Show outdated Hide outdated tests/raftstore/transport_simulate.rs Outdated
Show outdated Hide outdated src/server/server.rs Outdated
@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Oct 10, 2017

Contributor

PTAL @BusyJay

Contributor

siddontang commented Oct 10, 2017

PTAL @BusyJay

Show outdated Hide outdated src/server/transport.rs Outdated
@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Oct 10, 2017

Contributor

PTAL @BusyJay

Contributor

siddontang commented Oct 10, 2017

PTAL @BusyJay

@BusyJay

LGTM, the transport simulator is too complicated now, may need to be refactored later. /run-integration-tests

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Contributor

siddontang commented Oct 11, 2017

PTAL @overvenus

@overvenus

LGTM

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Oct 11, 2017

Member

/run-all-test

Member

overvenus commented Oct 11, 2017

/run-all-test

@siddontang siddontang merged commit cfdb313 into master Oct 11, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@siddontang siddontang deleted the siddontang/raft-router branch Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment