New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: adjust label checks #2372

Merged
merged 2 commits into from Oct 13, 2017

Conversation

Projects
None yet
5 participants
@BusyJay
Contributor

BusyJay commented Oct 11, 2017

Labels are case-insensitive, so accept upper case too.

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Oct 11, 2017

Contributor

LGTM

Contributor

siddontang commented Oct 11, 2017

LGTM

@huachaohuang

This comment has been minimized.

Show comment
Hide comment
@huachaohuang

huachaohuang Oct 11, 2017

Member

I think we should wait for PD to finish the case-insensitive conversion.

Member

huachaohuang commented Oct 11, 2017

I think we should wait for PD to finish the case-insensitive conversion.

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Contributor

siddontang commented Oct 12, 2017

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus
Member

overvenus commented Oct 12, 2017

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Oct 13, 2017

Contributor

Ping @disksing

Contributor

siddontang commented Oct 13, 2017

Ping @disksing

@disksing

LGTM

@siddontang siddontang merged commit c147f94 into master Oct 13, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@siddontang siddontang deleted the busyjay/adjust-labels-check branch Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment