New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv-ctl: refactor with debug API. #2377

Merged
merged 25 commits into from Oct 18, 2017

Conversation

Projects
None yet
5 participants
@hicqu
Contributor

hicqu commented Oct 12, 2017

Now tikv-ctl uses debug API so that it can work in both remote mode and local mode.

@hicqu hicqu requested a review from overvenus Oct 12, 2017

Show outdated Hide outdated src/raftstore/store/debug.rs
Show outdated Hide outdated src/raftstore/store/debug.rs
Show outdated Hide outdated src/raftstore/store/debug.rs
Show outdated Hide outdated src/bin/tikv-ctl.rs
@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Oct 12, 2017

Contributor

@BusyJay @overvenus , PTAL again, thanks.

Contributor

hicqu commented Oct 12, 2017

@BusyJay @overvenus , PTAL again, thanks.

Show outdated Hide outdated src/raftstore/store/debug.rs
Show outdated Hide outdated src/bin/tikv-ctl.rs
Show outdated Hide outdated src/bin/tikv-ctl.rs
Show outdated Hide outdated src/bin/tikv-ctl.rs

hicqu added some commits Oct 13, 2017

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Contributor

siddontang commented Oct 13, 2017

hicqu added some commits Oct 13, 2017

adjust command-line arguments.
I use some long options, for avoid name conflict.
@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Oct 13, 2017

Contributor

@BusyJay @overvenus , PTAL thanks.

Contributor

hicqu commented Oct 13, 2017

@BusyJay @overvenus , PTAL thanks.

Show outdated Hide outdated src/bin/tikv-ctl.rs
Show outdated Hide outdated src/bin/tikv-ctl.rs
Show outdated Hide outdated src/bin/tikv-ctl.rs
Show outdated Hide outdated src/bin/tikv-ctl.rs
Show outdated Hide outdated src/bin/tikv-ctl.rs
fn dump_all_region_info(&self, skip_tombstone: bool) {
for region in self.get_all_meta_regions() {
self.dump_region_info(region, skip_tombstone);

This comment has been minimized.

@BusyJay

BusyJay Oct 13, 2017

Contributor

I think you need to print region id before display its information.

@BusyJay

BusyJay Oct 13, 2017

Contributor

I think you need to print region id before display its information.

This comment has been minimized.

@hicqu

hicqu Oct 13, 2017

Contributor

fixed.

@hicqu

hicqu Oct 13, 2017

Contributor

fixed.

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Oct 16, 2017

Contributor

@BusyJay @overvenus PTAL, thanks.

Contributor

hicqu commented Oct 16, 2017

@BusyJay @overvenus PTAL, thanks.

Show outdated Hide outdated src/bin/tikv-ctl.rs
Show outdated Hide outdated src/bin/tikv-ctl.rs
Show outdated Hide outdated src/bin/tikv-ctl.rs
Show outdated Hide outdated src/bin/tikv-ctl.rs
Show outdated Hide outdated src/bin/tikv-ctl.rs
Show outdated Hide outdated src/bin/tikv-ctl.rs
Show outdated Hide outdated src/bin/tikv-ctl.rs
Show outdated Hide outdated src/bin/tikv-ctl.rs
Show outdated Hide outdated src/bin/tikv-ctl.rs
Show outdated Hide outdated src/bin/tikv-ctl.rs
@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Oct 17, 2017

Contributor

LGTM, @zhangjinpeng1987 PTAL, you may have different thoughts on command diff_region.

Contributor

BusyJay commented Oct 17, 2017

LGTM, @zhangjinpeng1987 PTAL, you may have different thoughts on command diff_region.

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Oct 18, 2017

Contributor

@BusyJay @zhangjinpeng1987 , PTAL thanks.

Contributor

hicqu commented Oct 18, 2017

@BusyJay @zhangjinpeng1987 , PTAL thanks.

hicqu added some commits Oct 18, 2017

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Oct 18, 2017

Contributor

/run-all-test

Contributor

hicqu commented Oct 18, 2017

/run-all-test

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Oct 18, 2017

Contributor

/run-all-test

Contributor

hicqu commented Oct 18, 2017

/run-all-test

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Oct 18, 2017

Contributor

/run-all-test

Contributor

hicqu commented Oct 18, 2017

/run-all-test

@hicqu hicqu merged commit e57a49c into master Oct 18, 2017

5 of 6 checks passed

jenkins-ci-tikv/integration-common-test Jenkins job failed
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tikv/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hicqu hicqu deleted the qupeng/debug-client branch Oct 18, 2017

hicqu added a commit to hicqu/tikv that referenced this pull request Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment