New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coprocessor, dag: implement `in` function. #2411

Merged
merged 8 commits into from Oct 25, 2017

Conversation

Projects
None yet
3 participants
@winoros
Contributor

winoros commented Oct 23, 2017

Support pushing in function down to tikv.
PTAL @AndreMouche

Show outdated Hide outdated src/coprocessor/dag/expr/compare.rs Outdated
),
(
ScalarFuncSig::InInt,
vec![Datum::I64(1), Datum::I64(2), Datum::Null],

This comment has been minimized.

@AndreMouche

AndreMouche Oct 24, 2017

Member

what about case vec![Datum::I64(1), Datum::I64(2), Datum::Null, Datum::I64(1)]?

@AndreMouche

AndreMouche Oct 24, 2017

Member

what about case vec![Datum::I64(1), Datum::I64(2), Datum::Null, Datum::I64(1)]?

This comment has been minimized.

@winoros

winoros Oct 24, 2017

Contributor

added

@winoros

winoros Oct 24, 2017

Contributor

added

@winoros

This comment has been minimized.

Show comment
Hide comment
@winoros
Contributor

winoros commented Oct 24, 2017

Show outdated Hide outdated src/coprocessor/dag/expr/compare.rs Outdated
Show outdated Hide outdated src/coprocessor/dag/expr/compare.rs Outdated
ScalarFuncSig::InDecimal |
ScalarFuncSig::InTime |
ScalarFuncSig::InDuration |
ScalarFuncSig::InJson => (2, usize::MAX),

This comment has been minimized.

@BusyJay

BusyJay Oct 24, 2017

Contributor

It seems that select NULL in (select * from test.test)s will get 0 if test.test is empty.

@BusyJay

BusyJay Oct 24, 2017

Contributor

It seems that select NULL in (select * from test.test)s will get 0 if test.test is empty.

This comment has been minimized.

@winoros

winoros Oct 24, 2017

Contributor

This case won't affect tikv's part.

@winoros

winoros Oct 24, 2017

Contributor

This case won't affect tikv's part.

Show outdated Hide outdated src/coprocessor/dag/expr/compare.rs Outdated
@winoros

This comment has been minimized.

Show comment
Hide comment
@winoros
Contributor

winoros commented Oct 25, 2017

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Oct 25, 2017

Contributor

LGTM

Contributor

BusyJay commented Oct 25, 2017

LGTM

@AndreMouche

LGTM

@winoros winoros merged commit 4b06c49 into tikv:master Oct 25, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@winoros winoros deleted the winoros:in_func branch Oct 25, 2017

zhangjinpeng1987 added a commit that referenced this pull request Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment