New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document defer macro LIFO behavior #2415

Merged
merged 2 commits into from Oct 25, 2017

Conversation

Projects
None yet
5 participants
@odeits
Contributor

odeits commented Oct 24, 2017

Documenting perhaps counter intuitive behavior of the macro. It is in compliance with the behavior of golangs defer. Confirmed with the experimient here https://play.rust-lang.org/?gist=6cf3013b12610150436c21bc2d5459ad&version=nightly

@sre-bot

This comment has been minimized.

Show comment
Hide comment
@sre-bot

sre-bot Oct 24, 2017

Collaborator

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

Collaborator

sre-bot commented Oct 24, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@ngaut

This comment has been minimized.

Show comment
Hide comment
@ngaut

ngaut Oct 24, 2017

Member

LGTM

Member

ngaut commented Oct 24, 2017

LGTM

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Oct 24, 2017

Contributor

PTAL @BusyJay

Contributor

siddontang commented Oct 24, 2017

PTAL @BusyJay

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Oct 25, 2017

Contributor

LGTM

Contributor

BusyJay commented Oct 25, 2017

LGTM

@ngaut

ngaut approved these changes Oct 25, 2017

@ngaut ngaut merged commit 1b764f1 into tikv:master Oct 25, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment