New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coprocessor: fix LIKE behaviour. #2442

Merged
merged 6 commits into from Nov 1, 2017

Conversation

Projects
None yet
3 participants
@hicqu
Contributor

hicqu commented Oct 31, 2017

No description provided.

@hicqu hicqu requested review from BusyJay, winoros and coocood Oct 31, 2017

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Oct 31, 2017

Contributor

@BusyJay @coocood PTAL, thanks.

Contributor

hicqu commented Oct 31, 2017

@BusyJay @coocood PTAL, thanks.

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Oct 31, 2017

Contributor

@BusyJay @coocood PTAL thanks.

Contributor

hicqu commented Oct 31, 2017

@BusyJay @coocood PTAL thanks.

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Oct 31, 2017

Contributor

/run-all-test

Contributor

hicqu commented Oct 31, 2017

/run-all-test

Show outdated Hide outdated src/coprocessor/dag/expr/compare.rs
Show outdated Hide outdated src/coprocessor/dag/expr/mod.rs
@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Oct 31, 2017

Contributor

/run-all-test

Contributor

hicqu commented Oct 31, 2017

/run-all-test

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Oct 31, 2017

Contributor

@coocood PTAL thanks.

Contributor

hicqu commented Oct 31, 2017

@coocood PTAL thanks.

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Nov 1, 2017

Contributor

/run-all-test

Contributor

hicqu commented Nov 1, 2017

/run-all-test

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Nov 1, 2017

Contributor

@coocood PTAL.

Contributor

hicqu commented Nov 1, 2017

@coocood PTAL.

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 1, 2017

Contributor

LGTM

Contributor

coocood commented Nov 1, 2017

LGTM

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Nov 1, 2017

Contributor

@BusyJay , PTAL again.

Contributor

hicqu commented Nov 1, 2017

@BusyJay , PTAL again.

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Nov 1, 2017

Contributor

LGTM, ci fails.

Contributor

BusyJay commented Nov 1, 2017

LGTM, ci fails.

@BusyJay

BusyJay approved these changes Nov 1, 2017

@hicqu hicqu merged commit 67125c8 into tikv:master Nov 1, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hicqu hicqu deleted the hicqu:hicqu/like-fix branch Nov 1, 2017

hicqu added a commit to hicqu/tikv that referenced this pull request Nov 6, 2017

hicqu added a commit that referenced this pull request Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment