New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: check gc target #2450

Merged
merged 4 commits into from Nov 6, 2017

Conversation

Projects
None yet
4 participants
@BusyJay
Contributor

BusyJay commented Nov 3, 2017

It's possible that the target is not the same as current peer, so remove the assert.

BusyJay added some commits Nov 3, 2017

@BusyJay BusyJay requested review from siddontang, hicqu and zhangjinpeng1987 Nov 3, 2017

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Nov 4, 2017

Contributor

LGTM

PTAL @overvenus @hicqu

Contributor

siddontang commented Nov 4, 2017

LGTM

PTAL @overvenus @hicqu

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Nov 4, 2017

Member

/run-all-test

Member

overvenus commented Nov 4, 2017

/run-all-test

@siddontang siddontang merged commit 405288a into tikv:master Nov 6, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment