New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coprocessor: fix do_div_mod bug #2456

Merged
merged 3 commits into from Nov 8, 2017

Conversation

Projects
None yet
5 participants
@mccxj
Contributor

mccxj commented Nov 6, 2017

for #2453

@sre-bot

This comment has been minimized.

Show comment
Hide comment
@sre-bot

sre-bot Nov 6, 2017

Collaborator

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

Collaborator

sre-bot commented Nov 6, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Nov 6, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Nov 6, 2017

CLA assistant check
All committers have signed the CLA.

@@ -591,7 +591,7 @@ fn do_div_mod(
let mut buf = vec![0; l_len];
(&mut buf[0..i]).copy_from_slice(&lhs.word_buf[l_idx..l_idx + i]);
let mut l_idx = 0;
let (r_start, mut r_stop) = (r_idx, word_cnt!(r_idx + r_prec as usize, usize) - 1);
let (r_start, mut r_stop) = (r_idx, r_idx + word_cnt!(r_prec as usize, usize) - 1);

This comment has been minimized.

@BusyJay

BusyJay Nov 6, 2017

Contributor

Any tests to cover it?

@BusyJay

BusyJay Nov 6, 2017

Contributor

Any tests to cover it?

This comment has been minimized.

@mccxj

mccxj Nov 6, 2017

Contributor

@BusyJay I'm adding test cases, please wait a minute.

@mccxj

mccxj Nov 6, 2017

Contributor

@BusyJay I'm adding test cases, please wait a minute.

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 6, 2017

Contributor

@mccxj
You can add test in decimal.rs:2854.

Contributor

coocood commented Nov 6, 2017

@mccxj
You can add test in decimal.rs:2854.

mccxj added some commits Nov 8, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 8, 2017

Contributor

LGTM

Contributor

coocood commented Nov 8, 2017

LGTM

@BusyJay

BusyJay approved these changes Nov 8, 2017

LGTM

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Nov 8, 2017

Contributor

/run-integration-tests

Contributor

BusyJay commented Nov 8, 2017

/run-integration-tests

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Nov 8, 2017

Contributor

Thanks!

Contributor

BusyJay commented Nov 8, 2017

Thanks!

@BusyJay BusyJay merged commit 0cb7a7d into tikv:master Nov 8, 2017

5 of 6 checks passed

jenkins-ci-tikv/integration-common-test Jenkins job failed
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@mccxj mccxj deleted the mccxj:patch-1 branch Nov 9, 2017

huachaohuang added a commit to huachaohuang/tikv that referenced this pull request Nov 10, 2017

huachaohuang added a commit that referenced this pull request Nov 10, 2017

Cherry pick commits to release-1.0 (#2466)
* config: add wal bytes per sync (#2407)

* Reset RocksDB statistics periodically (#2443)

* coprocessor: fix do_div_mod bug (#2456)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment