New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: unify ApplyContext and ExecContext #2457

Merged
merged 2 commits into from Nov 9, 2017

Conversation

Projects
None yet
3 participants
@BusyJay
Contributor

BusyJay commented Nov 7, 2017

So that we can reuse ApplyContext when implementing merge.

@BusyJay BusyJay requested review from siddontang, overvenus and hicqu Nov 7, 2017

pub sync_log: bool,
host: &'a CoprocessorHost,
wb: WriteBatch,
cbs: MustConsumeVec<(Callback, RaftCmdResponse)>,

This comment has been minimized.

@siddontang

siddontang Nov 8, 2017

Contributor

why do we need to check MustConsume?

@siddontang

siddontang Nov 8, 2017

Contributor

why do we need to check MustConsume?

This comment has been minimized.

@siddontang

siddontang Nov 8, 2017

Contributor

can we check this in the Context Drop? So we don't need to add a new struct.

@siddontang

siddontang Nov 8, 2017

Contributor

can we check this in the Context Drop? So we don't need to add a new struct.

This comment has been minimized.

@BusyJay

BusyJay Nov 8, 2017

Contributor

Because if RaftCmdResponse is leak, it may lead to dead lock in transaction layer. I want to move wb later, implement Drop will prevent moving any member fields.

@BusyJay

BusyJay Nov 8, 2017

Contributor

Because if RaftCmdResponse is leak, it may lead to dead lock in transaction layer. I want to move wb later, implement Drop will prevent moving any member fields.

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Nov 8, 2017

Contributor

LGTM
PTAL @overvenus

Contributor

siddontang commented Nov 8, 2017

LGTM
PTAL @overvenus

@overvenus

LGTM

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Nov 9, 2017

Contributor

/run-integration-tests

Contributor

BusyJay commented Nov 9, 2017

/run-integration-tests

@BusyJay BusyJay merged commit 69a7604 into tikv:master Nov 9, 2017

5 of 6 checks passed

jenkins-ci-tikv/integration-common-test Jenkins job failed
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@BusyJay BusyJay deleted the BusyJay:unify-context branch Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment