New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup mustconsumevec #2462

Merged
merged 1 commit into from Nov 10, 2017

Conversation

Projects
None yet
4 participants
@BusyJay
Contributor

BusyJay commented Nov 9, 2017

Use recover_safe! to hide the panic stacktrace and replace more code.

@BusyJay BusyJay requested review from siddontang, overvenus and hicqu Nov 9, 2017

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Nov 9, 2017

Contributor

LGTM

Contributor

siddontang commented Nov 9, 2017

LGTM

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Nov 9, 2017

Contributor

LGTM.

Contributor

hicqu commented Nov 9, 2017

LGTM.

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Nov 9, 2017

Contributor

/run-all-tests

Contributor

hicqu commented Nov 9, 2017

/run-all-tests

@hicqu

hicqu approved these changes Nov 9, 2017

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Nov 10, 2017

Collaborator

/run-integration-common-test

Collaborator

iamxy commented Nov 10, 2017

/run-integration-common-test

@BusyJay BusyJay merged commit 619ee08 into tikv:master Nov 10, 2017

6 of 7 checks passed

jenkins-ci-tikv/unit-test Jenkins job failed
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@BusyJay BusyJay deleted the BusyJay:cleanup-mustconsumevec branch Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment