Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherrypick rafactor tikv-ctl(#2377) #2668

Merged
merged 1 commit into from Jan 12, 2018

Conversation

@hicqu
Copy link
Contributor

hicqu commented Jan 10, 2018

Old tikv-server run on pb2, but after that we upgrade pb2 to pb3. So use latest tikv-ctl can't always access some old tikv cluster. This PR fix this.

@hicqu hicqu changed the title cherry pick rafactor tikv-ctl. cherrypick rafactor tikv-ctl(#2377) Jan 10, 2018
@hicqu

This comment has been minimized.

Copy link
Contributor Author

hicqu commented Jan 10, 2018

@zhangjinpeng1987

This comment has been minimized.

Copy link
Member

zhangjinpeng1987 commented Jan 10, 2018

It's better to test all these api first in existed cluster.

@hicqu hicqu requested review from BusyJay and zhangjinpeng1987 Jan 11, 2018
@zhangjinpeng1987

This comment has been minimized.

Copy link
Member

zhangjinpeng1987 commented Jan 11, 2018

LGTM

Copy link
Contributor

overvenus left a comment

lgtm

@ngaut ngaut merged commit 4681e37 into tikv:release-1.0 Jan 12, 2018
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@hicqu hicqu deleted the hicqu:release-1.0 branch Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.