Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: support cf for rawkv. #2852

Merged
merged 11 commits into from Apr 21, 2018
Merged

storage: support cf for rawkv. #2852

merged 11 commits into from Apr 21, 2018

Conversation

@disksing
Copy link
Collaborator

disksing commented Mar 21, 2018

Support specifying ColumnFamily in the rawkv APIs.
If cf is not specified in the request, CF_DEFAULT is used by default, so this feature is backward compatible.

disksing added 2 commits Mar 19, 2018
@siddontang

This comment has been minimized.

Copy link
Contributor

siddontang commented Mar 21, 2018

please add description for this PR.

@siddontang

This comment has been minimized.

Copy link
Contributor

siddontang commented Mar 22, 2018

LGTM

@huachaohuang

This comment has been minimized.

Copy link
Contributor

huachaohuang commented Mar 22, 2018

Can we use an enum for the cf name, since we only have a few valid cf?

@disksing

This comment has been minimized.

Copy link
Collaborator Author

disksing commented Mar 22, 2018

@huachaohuang In the future we may allow users to customize CFs or even create CFs dynamically.

@wentaoxu

This comment has been minimized.

Copy link
Contributor

wentaoxu commented Mar 22, 2018

LGTM

@siddontang

This comment has been minimized.

Copy link
Contributor

siddontang commented Apr 5, 2018

@disksing

I think we can go on now.

disksing added 2 commits Apr 9, 2018
# Conflicts:
#	Cargo.lock
#	src/server/service/kv.rs
#	src/storage/mod.rs
#	tests/storage/sync_storage.rs
@disksing disksing removed the S: DNM label Apr 9, 2018
# Conflicts:
#	Cargo.lock
@disksing

This comment has been minimized.

Copy link
Collaborator Author

disksing commented Apr 12, 2018

@breeswish

This comment has been minimized.

Copy link
Member

breeswish commented Apr 13, 2018

LGTM.

@breeswish

This comment has been minimized.

Copy link
Member

breeswish commented Apr 13, 2018

/run-integration-tests

disksing added 2 commits Apr 13, 2018
disksing added 3 commits Apr 16, 2018
# Conflicts:
#	tests/storage_cases/test_storage.rs
@breeswish breeswish merged commit 3b7c1c7 into tikv:master Apr 21, 2018
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@disksing disksing deleted the disksing:rawkv-cf branch Apr 21, 2018
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.