Join GitHub today
coprocessor/dag/expr: add builtin round function(RoundDec, RoundReal,… #3621
Signed-off-by: shizy firstname.lastname@example.org
What have you changed? (mandatory)
What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Please describe the tests that you ran to verify your changes. Have you finished unit tests, integration tests, or manual tests? What additional tests would give you greater confidence in this change?
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
Does this PR affect tidb-ansible update? (mandatory)
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)
Test result on my laptop is OK. I hope it gets same result on ci test this time.
NOTE: in the code, I still have to use name RouldReal defined in tipb. It is definitely a mistype and PR #97 to fix is already accepted. However if I update tipb version in Cargo.lock file and replace with RoundReal, I would get compile errors.
Because it removes set_encode_type in PR #96. It seems would affect more places.
I've no idea how to deal with this. @zz-jason any suggestion?
Sorry guys, I may not response promptly. But I will sure to check reply by the weekend.
@huachaohuang After I remove