Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: add builtin truncate_real #3633

Merged
merged 3 commits into from Sep 27, 2018

Conversation

@niedhui
Copy link
Contributor

commented Sep 25, 2018

Signed-off-by: niedhui niedhui@gmail.com

What have you changed? (mandatory)

implement builtin funciton: truncate_real

What are the type of the changes? (mandatory)

Improvement

How has this PR been tested? (mandatory)

unit test

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Refer to a related PR or issue link (optional)

#3275 #3532

Signed-off-by: niedhui <niedhui@gmail.com>
@sre-bot

This comment has been minimized.

Copy link
Collaborator

commented Sep 25, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

Copy link
Contributor

left a comment

LGTM

Copy link
Member

left a comment

Thanks! LGTM

breeswish added 2 commits Sep 25, 2018
@huachaohuang huachaohuang merged commit 20d5f9e into tikv:master Sep 27, 2018
3 checks passed
3 checks passed
DCO All commits are signed off!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
@AndreMouche AndreMouche referenced this pull request Dec 6, 2018
333 of 469 tasks complete
@niedhui niedhui deleted the niedhui:niedhui/truncate_real branch Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.