Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade grpcio to v0.4 #3650

Merged
merged 9 commits into from Oct 12, 2018

Conversation

@overvenus
Copy link
Contributor

commented Sep 30, 2018

What have you changed? (mandatory)

Upgrade grpcio to v0.4.0

What are the type of the changes? (mandatory)

  • Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

Unit tests.

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

Refer to a related PR or issue link (optional)

pingcap/kvproto#297

Benchmark result if necessary (optional)

TBD

overvenus added 3 commits Sep 21, 2018
*: upgrade grpcio to v0.4
Signed-off-by: Neil Shen <overvenus@gmail.com>
Fix tests
Signed-off-by: Neil Shen <overvenus@gmail.com>
Use crate io grpc
Signed-off-by: Neil Shen <overvenus@gmail.com>

@overvenus overvenus added the S: DNM label Sep 30, 2018

@siddontang
Copy link
Contributor

left a comment

LGTM

@ice1000
Copy link
Contributor

left a comment

LGTM

@overvenus

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2018

/run-all-tests

Update kvproto
Signed-off-by: Neil Shen <overvenus@gmail.com>

@overvenus overvenus dismissed stale reviews from ice1000 and siddontang via b2438ce Oct 9, 2018

@overvenus overvenus force-pushed the overvenus:grpcio-0.4 branch from 2031986 to b2438ce Oct 9, 2018

overvenus added 2 commits Oct 9, 2018
Add sync_region
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus

This comment has been minimized.

Copy link
Contributor Author

commented Oct 10, 2018

/run-unit-test

@ice1000
Copy link
Contributor

left a comment

LGTM

Update kvproto
Signed-off-by: Neil Shen <overvenus@gmail.com>

@overvenus overvenus removed the S: DNM label Oct 11, 2018

@hicqu

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2018

LGTM.

@hicqu
hicqu approved these changes Oct 11, 2018

@overvenus overvenus merged commit d1cd2ee into tikv:master Oct 12, 2018

2 checks passed

DCO All commits are signed off!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details

@overvenus overvenus deleted the overvenus:grpcio-0.4 branch Oct 12, 2018

overvenus added a commit to overvenus/tikv that referenced this pull request Oct 23, 2018
*: upgrade grpcio to v0.4 (tikv#3650)
Signed-off-by: Neil Shen <overvenus@gmail.com>
disksing added a commit that referenced this pull request Oct 23, 2018
*: upgrade grpcio to v0.4 (#3650) (#3704)
Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus added a commit that referenced this pull request Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.