New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: add more seek and seek_for_prev test #3722

Merged
merged 8 commits into from Nov 26, 2018

Conversation

Projects
None yet
5 participants
@Connor1996
Member

Connor1996 commented Oct 29, 2018

What have you changed? (mandatory)

add test for seek and seek_for_prev with different bound

What are the type of the changes? (mandatory)

  • Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

unit-test

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

add more seek and seek_prev test
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996

This comment has been minimized.

Member

Connor1996 commented Oct 29, 2018

@breeswish

This comment has been minimized.

Member

breeswish commented Oct 29, 2018

I think "reverse_seek" in the Iterator should be tested as well. It is expected to return None instead of Error for scenario: reverse_seek a for bound [a, b).

fix
Signed-off-by: Connor1996 <zbk602423539@gmail.com>

@ice1000 ice1000 added the C: Raft label Oct 29, 2018

@Hijiao

Hijiao approved these changes Nov 2, 2018

LGTM

@ice1000 ice1000 added the S: LGT2 label Nov 3, 2018

@zhangjinpeng1987

This comment has been minimized.

Member

zhangjinpeng1987 commented Nov 6, 2018

Ci failed.

Hijiao added some commits Nov 8, 2018

@Hijiao Hijiao merged commit 2c1e9ce into tikv:master Nov 26, 2018

2 of 3 checks passed

ci/circleci: test CircleCI is running your tests
Details
DCO All commits are signed off!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details

@Connor1996 Connor1996 deleted the Connor1996:seek-test branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment