Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv-ctl: Support raw scan #3825

Merged
merged 16 commits into from Jan 23, 2019

Conversation

@MyonKeminta
Copy link
Contributor

commented Nov 23, 2018

Signed-off-by: MyonKeminta MyonKeminta@users.noreply.github.com

What have you changed? (mandatory)

Add raw-scan subcommand to tikv-ctl.

What are the type of the changes? (mandatory)

  • New feature (non-breaking change which adds functionality)

How has this PR been tested? (mandatory)

  • Unit test

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

Yes

Does this PR affect tidb-ansible update? (mandatory)

No

support raw scan
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

@rleungx rleungx added the C: TiKV-Ctl label Nov 26, 2018

@zhangjinpeng1987
Copy link
Member

left a comment

LGTM

@MyonKeminta

This comment has been minimized.

Copy link
Contributor Author

commented Nov 27, 2018

Please wait. I plan to add some tests in this PR later.

@rleungx rleungx added the S: LGT1 label Nov 28, 2018

MyonKeminta added some commits Dec 6, 2018

add tests
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta

This comment has been minimized.

Copy link
Contributor Author

commented Dec 6, 2018

@zhangjinpeng1987 @hicqu PTAL thanks!

@rleungx

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

Could you also update the documentation in this PR?

MyonKeminta added some commits Dec 12, 2018

Add document
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta

This comment has been minimized.

Copy link
Contributor Author

commented Dec 12, 2018

@rleungx Done.

@MyonKeminta

This comment has been minimized.

Copy link
Contributor Author

commented Dec 18, 2018

@zhangjinpeng1987
Copy link
Member

left a comment

LGTM

zhangjinpeng1987 and others added some commits Dec 23, 2018

Merge branch 'master' of https://github.com/tikv/tikv into misono/tik…
…v-ctl-raw-scan

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Show resolved Hide resolved docs/tools/tikv-control.md Outdated
Show resolved Hide resolved docs/tools/tikv-control.md Outdated
Address comments
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Show resolved Hide resolved docs/tools/tikv-control.md Outdated
Show resolved Hide resolved src/bin/tikv-ctl.rs Outdated
Show resolved Hide resolved src/bin/tikv-ctl.rs Outdated
@overvenus

This comment has been minimized.

Copy link
Contributor

commented Jan 3, 2019

Any update?

MyonKeminta added some commits Jan 9, 2019

Address comments
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Do not limit in the range ['z', 'z' + 1)
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2019

I removed the constraint that the range must be in ['z', 'z' + 1) so we scan all things in the RocksDB. @rleungx @Hoverbear PTAL again thanks!

Use total_order_seek
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@overvenus
Copy link
Contributor

left a comment

LGTM

@Connor1996

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

Please update docs-cn

.help("at most how many keys to scan")
)
.arg(
Arg::with_name("cf")

This comment has been minimized.

Copy link
@Connor1996

Connor1996 Jan 16, 2019

Member

scan use show-cf, we should make them consistent

This comment has been minimized.

Copy link
@MyonKeminta

MyonKeminta Jan 16, 2019

Author Contributor

Scan's show-cf param indicates which CFs to show and which to hide. However, raw-scan scans a single CF, and the cf indicates which CF to scan. These two args are different.

@MyonKeminta

This comment has been minimized.

Copy link
Contributor Author

commented Jan 21, 2019

@zhangjinpeng1987
Copy link
Member

left a comment

LGTM

@MyonKeminta MyonKeminta merged commit 0f3f02a into tikv:master Jan 23, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@MyonKeminta MyonKeminta deleted the MyonKeminta:misono/tikv-ctl-raw-scan branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.