New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement builtin function: space #3841

Merged
merged 3 commits into from Nov 28, 2018

Conversation

Projects
None yet
5 participants
@niedhui
Contributor

niedhui commented Nov 27, 2018

What have you changed? (mandatory)

  1. implement builtin function: space
  2. limit capacity to avoid capacity overflow of VecDeque for substring_3_args.

What are the type of the changes? (mandatory)

  • Improvement
  • Bug fix

How has this PR been tested? (mandatory)

unit test

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Refer to a related PR or issue link (optional)

#3275 #3742

niedhui added some commits Nov 27, 2018

limit capacity to avoid capacity overflow
Signed-off-by: niedhui <niedhui@gmail.com>
implement cop builtin function: space
Signed-off-by: niedhui <niedhui@gmail.com>
@sre-bot

This comment has been minimized.

Collaborator

sre-bot commented Nov 27, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@ice1000

Neat!

@breeswish

Thanks a lot!

@breeswish breeswish added S: LGT2 and removed S: LGT1 labels Nov 28, 2018

@ngaut ngaut merged commit 13ac91c into tikv:master Nov 28, 2018

3 checks passed

DCO All commits are signed off!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details

@AndreMouche AndreMouche referenced this pull request Dec 6, 2018

Open

coprocessor/expression: push down scalar functions #3275

307 of 469 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment