New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: cherry-pick fixes of help messages of tikv-ctl #3846

Merged
merged 2 commits into from Nov 29, 2018

Conversation

Projects
None yet
4 participants
@MyonKeminta
Contributor

MyonKeminta commented Nov 28, 2018

Signed-off-by: MyonKeminta MyonKeminta@users.noreply.github.com

What have you changed? (mandatory)

This PR cherry-picks #3840 to release-2.1 branch
Later, another PR that will be submitted by @hicqu will also be picked in this PR.

What are the type of the changes? (mandatory)

  • Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

  • By manual tests

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

tikv-ctl: Some small fixes (#3840)
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

@MyonKeminta MyonKeminta changed the title from [WIP] release-2.1: cherry-pick fixes of tikv-ctl to [WIP] release-2.1: cherry-pick fixes of help messages of tikv-ctl Nov 28, 2018

@zhangjinpeng1987 zhangjinpeng1987 changed the title from [WIP] release-2.1: cherry-pick fixes of help messages of tikv-ctl to release-2.1: cherry-pick fixes of help messages of tikv-ctl Nov 29, 2018

@MyonKeminta MyonKeminta force-pushed the MyonKeminta:misono/cherry-pick-tikvctl-updates branch from 0e25d10 to 856b921 Nov 29, 2018

A quick fix for tombstone command's bad error message. (#3850)
Signed-off-by: qupeng <onlyqupeng@gmail.com>

@MyonKeminta MyonKeminta force-pushed the MyonKeminta:misono/cherry-pick-tikvctl-updates branch from 856b921 to 4f646e4 Nov 29, 2018

@MyonKeminta

This comment has been minimized.

Contributor

MyonKeminta commented Nov 29, 2018

@hicqu PTAL thanks!

@hicqu

hicqu approved these changes Nov 29, 2018

@hicqu

This comment has been minimized.

Contributor

hicqu commented Nov 29, 2018

LGTM.

@zhangjinpeng1987 zhangjinpeng1987 merged commit 46a31d5 into tikv:release-2.1 Nov 29, 2018

3 checks passed

DCO All commits are signed off!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment