New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A quick fix for tombstone command's bad error message. #3850

Merged
merged 3 commits into from Nov 28, 2018

Conversation

Projects
None yet
4 participants
@hicqu
Contributor

hicqu commented Nov 28, 2018

Signed-off-by: qupeng qupeng@pingcap.com

What have you changed? (mandatory)

Make the error message of tikv-ctl tombstone more clearly.

What are the type of the changes? (mandatory)

Improvement.

How has this PR been tested? (mandatory)

make dev.

hicqu added some commits Nov 28, 2018

A quick fix for tombstone command's bad error message.
Signed-off-by: qupeng <qupeng@pingcap.com>
@MyonKeminta

This comment has been minimized.

Contributor

MyonKeminta commented Nov 28, 2018

Could you please consider also document this pre-requirement in subcommand "tombstone"'s help message?

@rleungx rleungx added the C: TiKV-Ctl label Nov 28, 2018

@MyonKeminta

LGTM

@Connor1996

LGTM

@MyonKeminta MyonKeminta merged commit e772a8c into tikv:master Nov 28, 2018

3 checks passed

DCO All commits are signed off!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details

MyonKeminta added a commit to MyonKeminta/tikv that referenced this pull request Nov 29, 2018

MyonKeminta added a commit to MyonKeminta/tikv that referenced this pull request Nov 29, 2018

MyonKeminta added a commit to MyonKeminta/tikv that referenced this pull request Nov 29, 2018

A quick fix for tombstone command's bad error message. (tikv#3850)
Signed-off-by: qupeng <onlyqupeng@gmail.com>

@hicqu hicqu deleted the hicqu:tikv-ctl-improve branch Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment