New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/logger: collects logs of components #3859

Merged
merged 2 commits into from Nov 30, 2018

Conversation

Projects
None yet
4 participants
@overvenus
Member

overvenus commented Nov 29, 2018

What have you changed? (mandatory)

Collects logs of components.

What are the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

CI

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

Refer to a related PR or issue link (optional)

Close #3858

util/logger: collects logs of components
Signed-off-by: Neil Shen <overvenus@gmail.com>

@rleungx rleungx added the C: Util label Nov 29, 2018

@ice1000

LGTM

@overvenus

This comment has been minimized.

Member

overvenus commented Nov 30, 2018

Test failure is not related to this PR.

@overvenus overvenus merged commit 2bfc858 into tikv:master Nov 30, 2018

2 of 3 checks passed

ci/circleci: test Your tests failed on CircleCI
Details
DCO All commits are signed off!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details

@overvenus overvenus deleted the overvenus:tests/collect-logs branch Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment