New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coprocessor/dag/expr: AddDurationAndDuration #3984

Merged
merged 7 commits into from Jan 2, 2019

Conversation

Projects
None yet
5 participants
@GinYM
Copy link
Contributor

GinYM commented Dec 27, 2018

What have you changed? (mandatory)

implement builtin function: AddDurationAndDuration in coprocessor.
#3275

What are the type of the changes? (mandatory)

Improvement

How has this PR been tested? (mandatory)

Unit Test

Does this PR affect documentation (docs) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

GinYM added some commits Dec 27, 2018

partial
Signed-off-by: GinYM <jinyiming1996@gmail.com>
push down AddDurationAndDuration
Signed-off-by: GinYM <jinyiming1996@gmail.com>

Signed-off-by: GinYM <jinyiming1996@gmail.com>
@sre-bot

This comment has been minimized.

Copy link
Collaborator

sre-bot commented Dec 27, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

2 similar comments
@sre-bot

This comment has been minimized.

Copy link
Collaborator

sre-bot commented Dec 27, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@sre-bot

This comment has been minimized.

Copy link
Collaborator

sre-bot commented Dec 27, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@GinYM GinYM changed the title Add duration and duration coprocessor/dag/expr: AddDurationAndDuration Dec 27, 2018

@ice1000

This comment has been minimized.

Copy link
Member

ice1000 commented Dec 27, 2018

Please sign-off all your commits, thanks

@GinYM GinYM force-pushed the GinYM:AddDurationAndDuration branch from fc2e4c5 to c9ca738 Dec 27, 2018

GinYM added some commits Dec 27, 2018

AddDurationAndDuration resolve conflicts
Signed-off-by: GinYM <jinyiming1996@gmail.com>
Add #[inline]
Signed-off-by: GinYM <jinyiming1996@gmail.com>

@GinYM GinYM force-pushed the GinYM:AddDurationAndDuration branch from 4475439 to 383639c Dec 27, 2018

GinYM added some commits Dec 29, 2018

resolve conflicts
Signed-off-by: GinYM <jinyiming1996@gmail.com>
resolve conflict
Signed-off-by: GinYM <jinyiming1996@gmail.com>

@GinYM GinYM force-pushed the GinYM:AddDurationAndDuration branch from e5d6690 to 450b5ac Dec 29, 2018

@Hoverbear Hoverbear requested a review from ice1000 Dec 31, 2018

@huachaohuang
Copy link
Member

huachaohuang left a comment

LGTM

@huachaohuang huachaohuang merged commit 0de27a2 into tikv:master Jan 2, 2019

3 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details

@AndreMouche AndreMouche referenced this pull request Jan 17, 2019

Open

coprocessor/expression: push down scalar functions #3275

332 of 469 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment