Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new storage engine: Titan #3985

Merged
merged 21 commits into from Dec 29, 2018

Conversation

@DorianZheng
Copy link
Contributor

commented Dec 27, 2018

Signed-off-by: DorianZheng xingzhengde72@gmail.com

What have you changed? (mandatory)

Titan is new storage engine based on RocksDB which move large values to blob files in order to reduce the write amplification, such that it can provide better performance when the value of workload is large. Our experiments show that when the value of workload is > 1KB, the load and update performance of Titan is 2x better RocksDB, and the point read performance is better too. However, the range scan performance is worse than RocksDB.

What are the type of the changes? (mandatory)

New feature

How has this PR been tested? (mandatory)

Stress test

Does this PR affect documentation (docs) update? (mandatory)

Not yet

Does this PR affect tidb-ansible update? (mandatory)

Not yet

Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
@DorianZheng

This comment has been minimized.

Copy link
Contributor Author

commented Dec 27, 2018

@huachaohuang @zhangjinpeng1987 Don't give me approve yet, waiting for pingcap/rust-rocksdb#256

Cargo.toml Outdated Show resolved Hide resolved
@DorianZheng DorianZheng changed the title Merge titan Introduce a new storage engine: Titan Dec 27, 2018
src/config.rs Outdated Show resolved Hide resolved
DorianZheng added 12 commits Dec 28, 2018
Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
fix ci
Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
fix ci
Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
@DorianZheng

This comment has been minimized.

Copy link
Contributor Author

commented Dec 29, 2018

/rebuild

@huachaohuang

This comment has been minimized.

Copy link
Contributor

commented Dec 29, 2018

Please give some description about the configurations in config-template.toml.

DorianZheng added 2 commits Dec 29, 2018
Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
@DorianZheng DorianZheng added the P: High label Dec 29, 2018
src/config.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
tests/integrations/config/mod.rs Outdated Show resolved Hide resolved
tests/integrations/config/test-custom.toml Outdated Show resolved Hide resolved
etc/config-template.toml Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
etc/config-template.toml Outdated Show resolved Hide resolved
DorianZheng added 3 commits Dec 29, 2018
Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
DorianZheng added 2 commits Dec 29, 2018
@DorianZheng

This comment has been minimized.

Copy link
Contributor Author

commented Dec 29, 2018

/rebuild

Copy link
Contributor

left a comment

LGTM

@huachaohuang huachaohuang merged commit d34c30c into tikv:master Dec 29, 2018
3 checks passed
3 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci/build Jenkins job succeeded.
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
@DorianZheng DorianZheng deleted the DorianZheng:titan-master branch Dec 29, 2018
@DorianZheng DorianZheng referenced this pull request Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.